New/xline opeartor #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix500526
force-pushed
the
new/xline-opeartor
branch
4 times, most recently
from
e0178cf to
b3188f6
Compare
Phoenix500526
force-pushed
the
new/xline-opeartor
branch
3 times, most recently
from
5fb732d to
43886a1
Compare
Merged
Phoenix500526
force-pushed
the
new/xline-opeartor
branch
4 times, most recently
from
e196677 to
6830231
Compare
Merged
Phoenix500526
force-pushed
the
new/xline-opeartor
branch
2 times, most recently
from
1f6a4fb to
3ecc065
Compare
LingKa28
reviewed
Dec 27, 2023
iGxnon
reviewed
Jan 8, 2024
Phoenix500526
force-pushed
the
new/xline-opeartor
branch
4 times, most recently
from
5161292 to
9a5b7ab
Compare
Merged
Signed-off-by: Phoeniix Zhao <[email protected]>
Signed-off-by: Phoeniix Zhao <[email protected]>
Signed-off-by: Phoeniix Zhao <[email protected]>
Signed-off-by: Phoeniix Zhao <[email protected]>
Phoenix500526
force-pushed
the
new/xline-opeartor
branch
from
9a5b7ab to
c1f5574
Compare
bsbds
reviewed
Jan 15, 2024
| function test::ci::_chaos() { | ||
| size=$1 | ||
| iters=$2 | ||
| max_kill=$((size / 2)) |
There was a problem hiding this comment.
This should be (size - 1) /2
There was a problem hiding this comment.
The default behavior of integer division is always rounding down.
|
Duplicated with #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
Add an e2e test and run it in CI. Base on pr #46
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)